Switch SCD example to entity type natural
#4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recommend using the `natural` type for what is normally the `primary` entity in an SCD semantic model layout. The distinction is that `primary` indicates one row per entity value, while `natural` does not, and in an SCD context there is one row per entity value/time window set, rather than one row per entity value as in standard conformed dimension tables.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
|
Oh wait, we might need to include the |
mirnawong1
reviewed
Dec 12, 2023
|
hey @tlento i left. sugg but let me know if it's best to not add it per eng requirements 🙏 |
tlento
commented
Dec 12, 2023
Co-authored-by: mirnawong1 <[email protected]>
matthewshaver
approved these changes
Dec 13, 2023
|
Feedback merged - shipping. Thank you @tlento ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
This changes the entity type for the SCD example to
natural.We recommend using the
naturaltype for what is normally theprimaryentity in an SCD semantic model layout. The distinction is thatprimaryindicates one row per entity value, whilenaturaldoes not, and in an SCD context there is one row per entity value/time window set, rather than one row per entity value as in standard conformed dimension tables.Checklist