Add functional tests for unit testing #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
MichelleArk
force-pushed
the
test-unit-testing
branch
2 times, most recently
from
e67a397 to
88d2a47
Compare
MichelleArk
force-pushed
the
test-unit-testing
branch
from
88d2a47 to
688baa6
Compare
Merged
4 tasks
mikealfare
reviewed
Feb 9, 2024
MichelleArk
changed the title
mikealfare
approved these changes
Feb 20, 2024
MichelleArk
force-pushed
the
test-unit-testing
branch
from
4e3b10c to
fa083cf
Compare
3 tasks
4 tasks
MichelleArk
commented
May 13, 2024
| @@ -387,6 +387,7 @@ | |||
| "identifier": tmp_identifier | |||
| }) -%} | |||
|
|
|||
| {%- set tmp_relation = tmp_relation.include(database=false, schema=false) -%} | |||
There was a problem hiding this comment.
For posterity, I believe this change was made to avoid including the database and schema when rendering the create statement for a view, which was necessary by the unit testing framework.
I believe it could be implemented more precisely by the changes here: https://github.com/dbt-labs/dbt-spark/pull/978/files#diff-786bb6587e86e50a2d01888eb2d4a5257e9a0025f75379214fa93cd5a033c9fbR141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves ##987
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist