Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Testing] Add functional tests for unit testing: #987

Closed
3 tasks done
MichelleArk opened this issue Feb 20, 2024 · 1 comment
Closed
3 tasks done

[Unit Testing] Add functional tests for unit testing: #987

MichelleArk opened this issue Feb 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request triage

Comments

@MichelleArk
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Add spark-specific tests that implement the 3 base unit testing functional tests:

  1. BaseUnitTestingTypes
    • Core issue: case insensitive column names for unit test YML  dbt-core#9467
    • Currently, the unit testing framework in core uses the safe_cast utils macro to convert a user-provided value for an input mock to the appropriate type. In some instances, this safe_cast may fail and need special handling depending on the type.
    • The acceptance criteria for this issue is to introduce a test that provides coverage across all primative input types (and arrays & objects if possible!) for unit testing input data, potentially updating the safe_cast macro as necessary.
  2. BaseUnitTestCaseInsensivity
  3. TestSparkUnitTestInvalidInput

Describe alternatives you've considered

n/a

Who will this benefit?

dbt users of dbt-spark or adapters that extend dbt-spark :)

Are you interested in contributing this feature?

yep!

Anything else?

N/A

@MichelleArk MichelleArk added enhancement New feature or request triage labels Feb 20, 2024
@MichelleArk MichelleArk self-assigned this Feb 20, 2024
@MichelleArk
Copy link
Contributor Author

Resolved by: #976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

1 participant