-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acknowledge send_anonymous_usage_stats
setting for python models
#933
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cc69e6f
add draft integration test demonstrating the issue
mikealfare a32afdc
changie
mikealfare 65fafb2
add debug to run args for log capture
mikealfare 3c97e87
pin ddtrace to 1.x
mikealfare d769d22
condition on the send_anonymous_usage_stats setting when building a p…
mikealfare a273558
revert troubleshooting artifacts
mikealfare 488e0b5
Merge branch 'main' into bug/python-models/anonymous-usage
mikealfare 58ea51b
Merge branch 'main' into bug/python-models/anonymous-usage
mikealfare f78c2bf
Merge branch 'main' into bug/python-models/anonymous-usage
mikealfare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Fixes | ||
body: Acknowledge `send_anonymous_usage_stats` setting for python models | ||
time: 2024-03-18T20:36:35.396323-04:00 | ||
custom: | ||
Author: mikealfare | ||
Issue: "830" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
from dbt.tests.util import run_dbt_and_capture | ||
import pytest | ||
|
||
|
||
ANONYMOUS_USAGE_MESSAGE = """ | ||
sys._xoptions['snowflake_partner_attribution'].append("dbtLabs_dbtPython") | ||
""".strip() | ||
|
||
|
||
MY_PYTHON_MODEL = """ | ||
import pandas | ||
|
||
def model(dbt, session): | ||
dbt.config(materialized='table') | ||
data = [[1,2]] * 10 | ||
return pandas.DataFrame(data, columns=['test', 'test2']) | ||
""" | ||
|
||
|
||
class AnonymousUsageStatsBase: | ||
@pytest.fixture(scope="class") | ||
def models(self): | ||
return {"my_python_model.py": MY_PYTHON_MODEL} | ||
|
||
|
||
class TestAnonymousUsageStatsOn(AnonymousUsageStatsBase): | ||
@pytest.fixture(scope="class") | ||
def project_config_update(self): | ||
return {"flags": {"send_anonymous_usage_stats": True}} | ||
|
||
def test_stats_get_sent(self, project): | ||
_, logs = run_dbt_and_capture(["--debug", "run"]) | ||
assert ANONYMOUS_USAGE_MESSAGE in logs | ||
|
||
|
||
class TestAnonymousUsageStatsOff(AnonymousUsageStatsBase): | ||
@pytest.fixture(scope="class") | ||
def project_config_update(self, dbt_profile_target): | ||
return {"flags": {"send_anonymous_usage_stats": False}} | ||
|
||
def test_stats_do_not_get_sent(self, project): | ||
_, logs = run_dbt_and_capture(["--debug", "run"]) | ||
assert ANONYMOUS_USAGE_MESSAGE not in logs |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why's the indenting all weird?