Acknowledge send_anonymous_usage_stats setting for python models
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
mikealfare
changed the title
send_anonymous_usage_stats setting for python models
mikealfare
added
the
backport 1.7.latest
VersusFacit
approved these changes
Mar 21, 2024
VersusFacit
reviewed
Mar 21, 2024
| snowpark_telemetry_snippet = f""" | ||
| if self.config.args.SEND_ANONYMOUS_USAGE_STATS: | ||
| snowpark_telemetry_string = "dbtLabs_dbtPython" | ||
| snowpark_telemetry_snippet = f""" | ||
| import sys | ||
| sys._xoptions['snowflake_partner_attribution'].append("{snowpark_telemetry_string}")""" |
There was a problem hiding this comment.
Why's the indenting all weird?
mikealfare
added
backport 1.7.latest
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
) * add draft integration test demonstrating the issue * changie * condition on the send_anonymous_usage_stats setting when building a python model (cherry picked from commit ad7ea4d)
mikealfare
added a commit
that referenced
this pull request
Mar 21, 2024
…g for python models (#948) * Acknowledge `send_anonymous_usage_stats` setting for python models (#933) * add draft integration test demonstrating the issue * changie * condition on the send_anonymous_usage_stats setting when building a python model (cherry picked from commit ad7ea4d) * update how to turn send_anonymous_usage_stats on and off for 1.7 in the test fixtures --------- Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Mike Alfare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #830
Problem
We're not acknowledging the
send_anonymous_usage_statssetting for python models.Solution
SnowflakeAdapter.submit_python_jobto acknowledge this settingChecklist