Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and move semantics. #913

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Conversation

VersusFacit
Copy link
Contributor

resolves #912

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Feb 27, 2024
@cla-bot cla-bot bot added the cla:yes label Feb 27, 2024
@VersusFacit VersusFacit force-pushed the ADAP-912/add_test_for_PR_9682_in_core branch from dab036b to def1d47 Compare February 27, 2024 09:46
@mikealfare mikealfare merged commit 73b6a12 into main Mar 21, 2024
25 checks passed
@mikealfare mikealfare deleted the ADAP-912/add_test_for_PR_9682_in_core branch March 21, 2024 14:43
@mikealfare mikealfare added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Mar 21, 2024
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-913-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73b6a1203c305424370de3fc1bd511fe39b0a9c8
# Push it to GitHub
git push --set-upstream origin backport-913-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-913-to-1.6.latest.

github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
* Add test and move semantics
* Add FrozenSet to imports
* Tweak test failures
* remove extra semicolon

---------

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 73b6a12)
mikealfare added a commit that referenced this pull request Mar 21, 2024
* Add test and move semantics
* Add FrozenSet to imports
* Tweak test failures
* remove extra semicolon

---------

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 73b6a12)

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add test for 9682 in core against 1.8 and fix replace MV macros
2 participants