Add test and move semantics. (#913) (#946)

* Add test and move semantics * Add FrozenSet to imports * Tweak test failures * remove extra semicolon --------- Co-authored-by: Mila Page <[email protected]> Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 73b6a12) Co-authored-by: Mila Page <[email protected]> Co-authored-by: Mike Alfare <[email protected]>
dbt-labs · Mar 21, 2024 · bdc975e · bdc975e
1 parent b532809
commit bdc975e
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 9 deletions.
diff --git a/.changes/unreleased/Under the Hood-20240227-010428.yaml b/.changes/unreleased/Under the Hood-20240227-010428.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Add unit test for transaction semantics.
+time: 2024-02-27T01:04:28.713433-08:00
+custom:
+  Author: versusfacit
+  Issue: "912"
diff --git a/dbt/adapters/snowflake/relation.py b/dbt/adapters/snowflake/relation.py
@@ -1,5 +1,5 @@
 from dataclasses import dataclass, field
-from typing import Optional, Type
+from typing import FrozenSet, Optional, Type
 
 from dbt.adapters.base.relation import BaseRelation
 from dbt.adapters.relation_configs import RelationConfigChangeAction, RelationResults
@@ -20,13 +20,24 @@
 class SnowflakeRelation(BaseRelation):
     type: Optional[SnowflakeRelationType] = None  # type: ignore
     quote_policy: SnowflakeQuotePolicy = field(default_factory=lambda: SnowflakeQuotePolicy())
-    renameable_relations = frozenset({SnowflakeRelationType.Table, SnowflakeRelationType.View})
-    replaceable_relations = frozenset(
-        {
-            SnowflakeRelationType.DynamicTable,
-            SnowflakeRelationType.Table,
-            SnowflakeRelationType.View,
-        }
+
+    renameable_relations: FrozenSet[SnowflakeRelationType] = field(
+        default_factory=lambda: frozenset(
+            {
+                SnowflakeRelationType.Table,
+                SnowflakeRelationType.View,
+            }
+        )
+    )
+
+    replaceable_relations: FrozenSet[SnowflakeRelationType] = field(
+        default_factory=lambda: frozenset(
+            {
+                SnowflakeRelationType.DynamicTable,
+                SnowflakeRelationType.Table,
+                SnowflakeRelationType.View,
+            }
+        )
     )
 
     @property

diff --git a/dbt/include/snowflake/macros/relations/dynamic_table/create.sql b/dbt/include/snowflake/macros/relations/dynamic_table/create.sql
@@ -6,6 +6,5 @@
         as (
             {{ sql }}
         )
-    ;
 
 {%- endmacro %}
diff --git a/tests/unit/test_renamed_relations.py b/tests/unit/test_renamed_relations.py
@@ -0,0 +1,17 @@
+from dbt.adapters.snowflake.relation import SnowflakeRelation
+from dbt.adapters.snowflake.relation_configs import SnowflakeRelationType
+
+
+def test_renameable_relation():
+    relation = SnowflakeRelation.create(
+        database="my_db",
+        schema="my_schema",
+        identifier="my_table",
+        type=SnowflakeRelationType.Table,
+    )
+    assert relation.renameable_relations == frozenset(
+        {
+            SnowflakeRelationType.Table,
+            SnowflakeRelationType.View,
+        }
+    )
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,5 @@ @@
             as (
                 {{ sql }}
             )
-        ;
     {%- endmacro %}