Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/dynamic table alter on column syntax #790

Merged
merged 13 commits into from
Oct 11, 2023
Merged

Bug/dynamic table alter on column syntax #790

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7dfbb71
bug/Dynamic-table-comment-on-syntax
kaarthik108 Sep 13, 2023
48d9bf3
Add changelog
kaarthik108 Sep 13, 2023
9d27f02
Fix relation type
kaarthik108 Sep 14, 2023
248f609
Fix alter
kaarthik108 Sep 14, 2023
edbf910
Update dynamic table comment alter statement
patkearns10 Sep 27, 2023
3fa7547
Merge pull request #1 from patkearns10/patch-1
kaarthik108 Sep 27, 2023
104cb46
Merge branch 'main' into bug/Dynamic-table-comment-on-syntax
kaarthik108 Sep 27, 2023
6a3d86e
update comment on syntax
kaarthik108 Sep 27, 2023
70c97e2
Update changie
kaarthik108 Oct 2, 2023
0c8299e
Merge branch 'main' into bug/Dynamic-table-comment-on-syntax
kaarthik108 Oct 2, 2023
ebfdf87
Merge branch 'main' into bug/Dynamic-table-comment-on-syntax
mikealfare Oct 10, 2023
7184cd5
Removed old changelog
kaarthik108 Oct 11, 2023
fb05919
Merge branch 'main' into bug/Dynamic-table-comment-on-syntax
colin-rogers-dbt Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230914-110800.yaml
View file
Open in desktop
kaarthik108 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fixing comment on syntax for dynamic tables
time: 2023-09-14T11:08:00.250684+12:00
custom:
Author: kaarthik108
Issue: '769'
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20231002-144648.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix the alter syntax on column for dynamic table
time: 2023-10-02T14:46:48.980242+13:00
custom:
Author: kaarthik108
Issue: "769"
2 changes: 1 addition & 1 deletion dbt/include/snowflake/macros/adapters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
{% macro snowflake__alter_column_comment(relation, column_dict) -%}
{% set existing_columns = adapter.get_columns_in_relation(relation) | map(attribute="name") | list %}
{% if relation.is_dynamic_table -%}
{% set relation_type = "dynamic table" %}
{% set relation_type = "table" %}
{% else -%}
{% set relation_type = relation.type %}
{% endif %}
Expand Down