Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/dynamic table alter on column syntax #790

Merged
merged 13 commits into from
Oct 11, 2023
Merged

Bug/dynamic table alter on column syntax #790

merged 13 commits into from
Oct 11, 2023

Conversation

kaarthik108
Copy link
Contributor

@kaarthik108 kaarthik108 commented Sep 27, 2023 •
edited by dbeatty10
Loading

Resolves #769
docs dbt-labs/docs.getdbt.com/#

Problem

Fix the alter syntax for dynamic table

Solution

alter table table_name instead of alter dynamic table

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@kaarthik108 kaarthik108 requested a review from a team as a code owner September 27, 2023 22:11
@cla-bot cla-bot bot added the cla:yes label Sep 27, 2023
@kaarthik108 kaarthik108 mentioned this pull request Oct 2, 2023
Closed
2 tasks
@kaarthik108 kaarthik108 changed the title Bug/dynamic table comment on syntax Bug/dynamic table alter on column syntax Oct 2, 2023
@kaarthik108
Copy link
Contributor Author

@mikealfare Just adding you here as you previously reviewed. Thanks

@patkearns10 patkearns10 requested a review from mikealfare October 2, 2023 03:13
@mikealfare mikealfare merged commit 69168e7 into dbt-labs:main Oct 11, 2023
30 of 37 checks passed
@mikealfare
Copy link
Contributor

Thanks @kaarthik108 and @colin-rogers-dbt!

philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
@kaarthik108 @patkearns10
@mikealfare @colin-rogers-dbt @philippe-boyd-maxa
Bug/dynamic table alter on column syntax (dbt-labs#790)
6c684b4 
* bug/Dynamic-table-comment-on-syntax
* Add changelog
* Fix relation type
* Fix alter
* Update dynamic table comment alter statement
* update comment on syntax

---------

Co-authored-by: Pat Kearns <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: colin-rogers-dbt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes ok to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-885] [Bug] Dynamic table alter syntax and comment syntax is wrong
4 participants
@kaarthik108 @mikealfare @colin-rogers-dbt @patkearns10