-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snowflake telemetry. #1209
Add snowflake telemetry. #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one question, is it worth adding a test to this since we are tracking an additional dbt-snowflake
-specific attribute?
I suppose it's worth adding a unit test (done) because this gives us extra security with base adapter / core calls that could be tripped up through many layers of indirection. |
Related to dbt-labs/dbt-adapters#301
Problem
We need a snowflake override to get the data for snowflake.
Solution
Override the base class method.
Checklist