Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapter telemetry method for core model run snowplow event. #328

Merged
merged 13 commits into from
Oct 28, 2024

Conversation

VersusFacit
Copy link
Contributor

resolves #301
docs dbt-labs/docs.getdbt.com/#

Problem

We need a way to expose adapter telemetry for our internal product adoption analytics.

Solution

The base adapter provides a simple method which is used in dbt core and its tracking system. This method will be overwritten for each adapter that we wish to collect telemetry for.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit requested a review from a team as a code owner October 16, 2024 10:27
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@VersusFacit
Copy link
Contributor Author

Proof of operation for fallback method (i.e. adapter does not override)

image

Note adapter_details is {}. It'll be non-empty in, say, snowflake (here) which provides an override with snowflake-specific info. This field is optional in our JSON schema.

@colin-rogers-dbt colin-rogers-dbt self-requested a review October 18, 2024 18:18
@colin-rogers-dbt
Copy link
Contributor

Is this unit test-able?

dbt/adapters/base/impl.py Outdated Show resolved Hide resolved
dbt/adapters/base/impl.py Show resolved Hide resolved
dbt/adapters/base/impl.py Show resolved Hide resolved
mikealfare
mikealfare previously approved these changes Oct 23, 2024
@VersusFacit VersusFacit merged commit d83314d into main Oct 28, 2024
14 checks passed
@VersusFacit VersusFacit deleted the ADAP-301/add-adapter-telemetry branch October 28, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Adapters Model Configuration Snowplow Tracking
3 participants