Add Conversion Metrics Properties #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
WilliamDee
force-pushed
the
will/add-conversion-metric
branch
from
549313e to
8c2f986
Compare
WilliamDee
force-pushed
the
will/add-conversion-metric
branch
from
8c2f986 to
30890ae
Compare
WilliamDee
force-pushed
the
will/add-conversion-metric
branch
from
30890ae to
b93ac79
Compare
tlento
reviewed
Nov 28, 2023
There was a problem hiding this comment.
I think there's a general issue of too many accessors, and I think we'll be better off starting with more streamlined protocols. In particular, I'd like to avoid the get_property_or_error accessor pattern you've introduced here.
Otherwise, this looks good. We can see if @QMalcolm has any added feedback while we clean up the accessors.
QMalcolm
approved these changes
Nov 29, 2023
This was referenced Nov 30, 2023
4 tasks
WilliamDee
added a commit
that referenced
this pull request
Dec 7, 2023
### Description Backporting conversion metric support PRs to `0.4.latest` - #221 - #209 <!--- Describe the Pull Request here. Add any references and info to help reviewers understand your changes. Include any tradeoffs you considered. --> ### Checklist - [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me - [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) - [x] This PR includes tests, or tests are not required/relevant for this PR - [x] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spec
Reference #210
Checklist
changie newto create a changelog entry