Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 0.4.latest] Add support for conversion metrics #224

Merged
merged 10 commits into from
Dec 7, 2023

Conversation

WilliamDee
Copy link
Contributor

@WilliamDee WilliamDee commented Dec 6, 2023

Description

Backporting conversion metric support PRs to 0.4.latest

Checklist

@cla-bot cla-bot bot added the cla:yes label Dec 6, 2023
@WilliamDee WilliamDee force-pushed the will/backport-conversion-metrics branch from 46343c3 to f75e9b1 Compare December 6, 2023 21:44
WilliamDee and others added 10 commits December 6, 2023 16:48
Resolves #211

<!---
Include the number of the issue addressed by this PR above if
applicable.
  PRs for code changes without an associated issue *will not be merged*.
  See CONTRIBUTING.md for more information.
-->

### Description
Added validations for conversion metric configs.

#### Rules pulled from #211
1. entity must exist in both the semantic models that the base_measure
and conversion_measure are in
2. base_measure and conversion_measure must be valid and can only be
SUM(1) or COUNT or DISTINCT_COUNT measures
3. In constant_properties, both property that is stated must be
referencing either an existing dimension/entity in the respective
base/conversion semantic model

<!---
Describe the Pull Request here. Add any references and info to help
reviewers
  understand your changes. Include any tradeoffs you considered.
-->

### Checklist

- [x] I have read [the contributing
guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md)
and understand what's expected of me
- [x] I have signed the
[CLA](https://docs.getdbt.com/docs/contributor-license-agreements)
- [x] This PR includes tests, or tests are not required/relevant for
this PR
- [x] I have run `changie new` to [create a changelog
entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
@WilliamDee WilliamDee force-pushed the will/backport-conversion-metrics branch from f75e9b1 to 625589a Compare December 6, 2023 21:48
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for handling this 🙂

@WilliamDee WilliamDee merged commit 0d896f9 into 0.4.latest Dec 7, 2023
8 checks passed
@WilliamDee WilliamDee deleted the will/backport-conversion-metrics branch December 7, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants