Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent typing-extensions from auto-updating to 5.x #200

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

tlento
Copy link
Collaborator

@tlento tlento commented Oct 26, 2023

The typing-extensions project announced adherence to semver with
4.0.0, which means, at least in theory, 5.0 might include
breaking changes.

Rather than risk user packages auto-updating to backwards-incompatible
versions, we pin this back to ~=4.4, which is equivalent to >=4.4, <5.

@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

The typing-extensions project announced adherence to semver with
4.0.0, which means, at least in theory, 5.0 might include
breaking changes.

Rather than risk user packages auto-updating to backwards-incompatible
versions, we pin this back to ~=4.0, which is equivalent to >=4.0, <5.
@tlento tlento force-pushed the restrict-typing-extensions branch from 7345bed to 72e272e Compare October 26, 2023 23:12
@tlento tlento requested a review from QMalcolm October 26, 2023 23:14
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@tlento tlento merged commit 9f478a3 into main Oct 30, 2023
6 checks passed
@tlento tlento deleted the restrict-typing-extensions branch October 30, 2023 18:28
tlento added a commit that referenced this pull request Nov 4, 2023
The typing-extensions project announced adherence to semver with
4.0.0, which means, at least in theory, 5.0 might include
breaking changes.

Rather than risk user packages auto-updating to backwards-incompatible
versions, we pin this back to ~=4.0, which is equivalent to >=4.0, <5.
tlento added a commit that referenced this pull request Nov 6, 2023
- Update typing-extensions to require versions >=4.4 (#194)
- Prevent typing-extensions from auto-updating to 5.x (#200)

---------

Co-authored-by: Alexander Tikhonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants