Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport typing extensions version update to 0.4 #205

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

tlento
Copy link
Collaborator

@tlento tlento commented Nov 4, 2023

Fatal1ty and others added 2 commits November 3, 2023 16:56
Support for the `@override` keyword was added with typing-extensions 4.4,
but the previous version spec made it possible for end users to encounter
errors when attempting to use dbt or MetricFlow.
The typing-extensions project announced adherence to semver with
4.0.0, which means, at least in theory, 5.0 might include
breaking changes.

Rather than risk user packages auto-updating to backwards-incompatible
versions, we pin this back to ~=4.0, which is equivalent to >=4.0, <5.
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tlento tlento merged commit b37be4a into 0.4.latest Nov 6, 2023
9 checks passed
@tlento tlento deleted the 0.4-typing-extensions-backport branch November 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants