Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing-extensions>=4.4 requirement #194

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add typing-extensions>=4.4 requirement #194

merged 2 commits into from
Oct 26, 2023

Conversation

Fatal1ty
Copy link
Contributor

@Fatal1ty Fatal1ty commented Oct 26, 2023

Resolves #193
Related to dbt-labs/dbt-core#7828

Description

Checklist

@cla-bot
Copy link

cla-bot bot commented Oct 26, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @Fatal1ty

@cla-bot
Copy link

cla-bot bot commented Oct 26, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alexander Tikhonov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@dbeatty10
Copy link

Thanks for raising this PR @Fatal1ty !

We'll see if one of our engineers is available to give this an initial look.

Copy link
Collaborator

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, and sorry for the thrash! We'll dig into this on our side to make sure we can deploy fixed up versions across the board.

@tlento tlento added the Backport 0.2.latest Fix should be backported to 0.2.latest label Oct 26, 2023
@tlento tlento merged commit 8ed8148 into dbt-labs:main Oct 26, 2023
26 checks passed
tlento pushed a commit that referenced this pull request Oct 26, 2023
Support for the `@override` keyword was added with typing-extensions 4.4,
but the previous version spec made it possible for end users to encounter
errors when attempting to use dbt or MetricFlow.
tlento added a commit that referenced this pull request Oct 30, 2023
…199)

Support for the `@override` keyword was added with typing-extensions
4.4,
but the previous version spec made it possible for end users to
encounter
errors when attempting to use dbt or MetricFlow.

---------

Co-authored-by: Alexander Tikhonov <[email protected]>
tlento pushed a commit that referenced this pull request Nov 4, 2023
Support for the `@override` keyword was added with typing-extensions 4.4,
but the previous version spec made it possible for end users to encounter
errors when attempting to use dbt or MetricFlow.
tlento added a commit that referenced this pull request Nov 6, 2023
- Update typing-extensions to require versions >=4.4 (#194)
- Prevent typing-extensions from auto-updating to 5.x (#200)

---------

Co-authored-by: Alexander Tikhonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport 0.2.latest Fix should be backported to 0.2.latest cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import override from typing_extensions~=4.0
3 participants