-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing-extensions>=4.4 requirement #194
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @Fatal1ty |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alexander Tikhonov.
|
Thanks for raising this PR @Fatal1ty ! We'll see if one of our engineers is available to give this an initial look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, and sorry for the thrash! We'll dig into this on our side to make sure we can deploy fixed up versions across the board.
Support for the `@override` keyword was added with typing-extensions 4.4, but the previous version spec made it possible for end users to encounter errors when attempting to use dbt or MetricFlow.
…199) Support for the `@override` keyword was added with typing-extensions 4.4, but the previous version spec made it possible for end users to encounter errors when attempting to use dbt or MetricFlow. --------- Co-authored-by: Alexander Tikhonov <[email protected]>
Support for the `@override` keyword was added with typing-extensions 4.4, but the previous version spec made it possible for end users to encounter errors when attempting to use dbt or MetricFlow.
- Update typing-extensions to require versions >=4.4 (#194) - Prevent typing-extensions from auto-updating to 5.x (#200) --------- Co-authored-by: Alexander Tikhonov <[email protected]>
Resolves #193
Related to dbt-labs/dbt-core#7828
Description
Checklist
changie new
to create a changelog entry