replace dbt/common with dbt-common #9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9342 +/- ##
==========================================
+ Coverage 86.65% 87.08% +0.43%
==========================================
Files 230 184 -46
Lines 27060 23937 -3123
==========================================
- Hits 23448 20846 -2602
+ Misses 3612 3091 -521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5 tasks
emmyoop
reviewed
Jan 9, 2024
Comment on lines
-67
to
-70
| "colorama>=0.3.9,<0.5", | ||
| "pathspec>=0.9,<0.12", | ||
| "isodate>=0.6,<0.7", | ||
| # ---- |
There was a problem hiding this comment.
colorama and isodate moved to dbt-common!
emmyoop
reviewed
Jan 9, 2024
MichelleArk
commented
Jan 10, 2024
* tried blinding cutting out all logbook dependency related bits * cleanup * changelog * remove import * remove unused import
|
9k lines deleted, niiiiice ❤️ |
colin-rogers-dbt
approved these changes
Jan 12, 2024
mikealfare
approved these changes
Jan 12, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9357
Problem
The contents of dbt/common are being moved to dbt-common, so we can now delete dbt/common and its associated tests/dependencies!
Solution
Checklist