Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dbt/common req in favor of dbt-common dependency #9368

Merged
merged 15 commits into from
Jan 16, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 12, 2024

resolves #9357

Problem

Pull out dbt/common and add dbt-common as a dependency. Legacy logger remains in the code for now.

Solution

Pull out dbt/common and add dbt-common as a dependency.

leave in legacy logger for now.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 12, 2024
@emmyoop emmyoop changed the title Er/remove common req keep legacy logger remove dbt/common req in favor of dbt-common dependency Jan 12, 2024
@emmyoop emmyoop force-pushed the er/remove-common-req-keep-legacy-logger branch from 2e36ac5 to cdbaf94 Compare January 12, 2024 20:10
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (a1f78a8) 86.67% compared to head (27a2840) 86.71%.

Files Patch % Lines
core/dbt/adapters/base/connections.py 28.57% 10 Missing ⚠️
core/dbt/contracts/graph/manifest.py 50.00% 7 Missing ⚠️
core/dbt/adapters/sql/connections.py 63.63% 4 Missing ⚠️
core/dbt/task/base.py 55.55% 4 Missing ⚠️
core/dbt/task/sql.py 0.00% 4 Missing ⚠️
core/dbt/logger.py 40.00% 3 Missing ⚠️
core/dbt/adapters/base/relation.py 50.00% 2 Missing ⚠️
core/dbt/task/debug.py 83.33% 2 Missing ⚠️
core/dbt/contracts/sql.py 0.00% 1 Missing ⚠️
core/dbt/task/docs/generate.py 85.71% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9368      +/-   ##
==========================================
+ Coverage   86.67%   86.71%   +0.03%     
==========================================
  Files         230      185      -45     
  Lines       27060    24321    -2739     
==========================================
- Hits        23455    21089    -2366     
+ Misses       3605     3232     -373     
Flag Coverage Δ
integration 84.03% <89.56%> (+0.39%) ⬆️
unit 63.71% <86.25%> (-1.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk
Copy link
Contributor

I can't comment directly on the line but I also ran into the failing code quality check for in unparsed.py in #9342 and couldn't find a great workaround for it beyond just ignoring.

@emmyoop emmyoop marked this pull request as ready for review January 16, 2024 14:41
@emmyoop emmyoop requested review from a team as code owners January 16, 2024 14:41
@emmyoop emmyoop merged commit 15704ab into main Jan 16, 2024
51 checks passed
@emmyoop emmyoop deleted the er/remove-common-req-keep-legacy-logger branch January 16, 2024 19:39
@dbeatty10 dbeatty10 mentioned this pull request Feb 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3538] [Adapter Decoupling] Add dbt-common as dependency and remove dbt/common subdir
3 participants