-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dbt/common req in favor of dbt-common dependency #9368
Conversation
2e36ac5
to
cdbaf94
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9368 +/- ##
==========================================
+ Coverage 86.67% 86.71% +0.03%
==========================================
Files 230 185 -45
Lines 27060 24321 -2739
==========================================
- Hits 23455 21089 -2366
+ Misses 3605 3232 -373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I can't comment directly on the line but I also ran into the failing code quality check for in unparsed.py in #9342 and couldn't find a great workaround for it beyond just ignoring. |
resolves #9357
Problem
Pull out dbt/common and add dbt-common as a dependency. Legacy logger remains in the code for now.
Solution
Pull out dbt/common and add dbt-common as a dependency.
leave in legacy logger for now.
Checklist