Model contracts: raise warning for numeric types without specified scale #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8721 +/- ##
=======================================
Coverage 86.65% 86.66%
=======================================
Files 176 176
Lines 25674 25765 +91
=======================================
+ Hits 22248 22329 +81
- Misses 3426 3436 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gshank
approved these changes
Sep 26, 2023
Co-authored-by: colin-rogers-dbt <[email protected]>
emmyoop
commented
Sep 26, 2023
emmyoop
commented
Sep 26, 2023
colin-rogers-dbt
approved these changes
Sep 26, 2023
QMalcolm
pushed a commit
that referenced
this pull request
Oct 9, 2023
…ale (#8721) * add warning when contracting fields don't have precision * rename files * changelog * move tests out of adapter zone * Update core/dbt/include/global_project/macros/adapters/columns.sql Co-authored-by: colin-rogers-dbt <[email protected]> * Apply suggestions from code review --------- Co-authored-by: colin-rogers-dbt <[email protected]>
|
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4251 |
runleonarun
added a commit
to dbt-labs/docs.getdbt.com
that referenced
this pull request
Oct 11, 2023
…view) (#4258) closes #4251 Captures this Core change: dbt-labs/dbt-core#8721 This PR adds more context for rules, adds an example, and notes that core includes an error for 1.7 and higher. Note: This PR reverts #4257 which reverted #4255 --------- Co-authored-by: Emily Rockman <[email protected]>
5 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8183
Problem
Enforces contracts with numeric types that don't specify scale run the risk of failing contract enforcement. This is actually confusing as they're not actually intentionally failing, the precision just needs to be specified so it can be enforced instead of applying the default.
Solution
If the user has provided a numeric data type, which should specify precision/scale, without having specified anything except the type, raise a warning.
Checklist