Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contract.md to include specific rules (reverted to get tech review) #4258

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Oct 11, 2023

closes #4251

Captures this Core change: dbt-labs/dbt-core#8721

This PR adds more context for rules, adds an example, and notes that core includes an error for 1.7 and higher.

Note: This PR reverts #4257 which reverted #4255

@runleonarun runleonarun requested a review from a team as a code owner October 11, 2023 20:18
@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 8:58pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Oct 11, 2023
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR just enabled a warning, not an error.

website/docs/reference/resource-configs/contract.md Outdated Show resolved Hide resolved
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!

@runleonarun runleonarun merged commit 18061b7 into current Oct 11, 2023
6 checks passed
@runleonarun runleonarun deleted the revert-4257-revert-4255-runleonarun-patch-10 branch October 11, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model contract: raise warning if numeric data type without specified precision/scale
2 participants