-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contract.md to include specific rules (reverted to get tech review) #4258
Merged
runleonarun
merged 5 commits into
current
from
revert-4257-revert-4255-runleonarun-patch-10
Oct 11, 2023
Merged
Update contract.md to include specific rules (reverted to get tech review) #4258
runleonarun
merged 5 commits into
current
from
revert-4257-revert-4255-runleonarun-patch-10
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ecd1fd5.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
size: x-small
This change will take under 3 hours to fix.
Docs team
Authored by the Docs team @dbt Labs
labels
Oct 11, 2023
runleonarun
commented
Oct 11, 2023
runleonarun
commented
Oct 11, 2023
emmyoop
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR just enabled a warning, not an error.
Co-authored-by: Emily Rockman <[email protected]>
emmyoop
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
size: x-small
This change will take under 3 hours to fix.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4251
Captures this Core change: dbt-labs/dbt-core#8721
This PR adds more context for rules, adds an example, and notes that core includes an error for 1.7 and higher.
Note: This PR reverts #4257 which reverted #4255