Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codes to all log events (re-work of PR #4268) #4319

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add codes to all log events (re-work of PR #4268) #4319

merged 2 commits into from
Nov 22, 2021

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Nov 22, 2021 •
edited
Loading

resolves (No Issue, mentioned in #4260)

Description

Re-work of PR #4268
See comments / discussion there.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 22, 2021
@iknox-fa iknox-fa marked this pull request as ready for review November 22, 2021 18:20
@iknox-fa iknox-fa mentioned this pull request Nov 22, 2021
Closed
26 tasks
emmyoop
emmyoop approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes look good as far as I can tell.

core/dbt/events/types.py
return f"command return code={self.code}"
return f"command return code={self.returncode}"

# TODO remove?? Not called outside of this file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to remove anything not called outside this file. I know with all the merges that were happening some log lines got removed due to other tasks but we didn't get the events pulled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good to know. I don't think I'll do it now just because we want to get this in ASAP but I'll try to pick it up next time I touch this file.

@iknox-fa iknox-fa merged commit e1a2e8d into main Nov 22, 2021
@iknox-fa iknox-fa deleted the logging-codes-2 branch November 22, 2021 19:14
@nathaniel-may
Copy link
Contributor

Just for any future github spelunkers, it looks like we missed the tests from #4268. The work to re add these is outlined in #4329.

@nathaniel-may nathaniel-may mentioned this pull request Nov 23, 2021
Closed
iknox-fa added a commit that referenced this pull request Feb 8, 2022
@iknox-fa
Add codes to all log events (re-work of PR #4268) (#4319)
941de38 
* re-work of old branch

automatic commit by git-black, original commits:
  e1a2e8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@kwigley kwigley Awaiting requested review from kwigley

@gshank gshank Awaiting requested review from gshank

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iknox-fa @nathaniel-may @emmyoop