Add codes to all log events (re-work of PR #4268) (#4319)

* re-work of old branch

CHANGELOG.md

@@ -9,6 +9,7 @@
 - Allow `--defer` flag to `dbt snapshot` ([#4110](https://github.com/dbt-labs/dbt-core/issues/4110), [#4296](https://github.com/dbt-labs/dbt-core/pull/4296))
 - Install prerelease packages when `version` explicitly references a prerelease version, regardless of `install-prerelease` status ([#4243](https://github.com/dbt-labs/dbt-core/issues/4243), [#4295](https://github.com/dbt-labs/dbt-core/pull/4295))
 - Add data attributes to json log messages[#4301](https://github.com/dbt-labs/dbt-core/pull/4301)
+- Add event codes to all log events([#4319](https://github.com/dbt-labs/dbt-core/pull/4319))
 
 ### Fixes
 - Fix serialization error with missing quotes in metrics model ref ([#4252](https://github.com/dbt-labs/dbt-core/issues/4252), [#4287](https://github.com/dbt-labs/dbt-core/pull/4289))

core/dbt/clients/system.py

@@ -441,7 +441,7 @@ def run_cmd(
     fire_event(SystemStdErrMsg(bmsg=err))
 
     if proc.returncode != 0:
-        fire_event(SystemReportReturnCode(code=proc.returncode))
+        fire_event(SystemReportReturnCode(returncode=proc.returncode))
         raise dbt.exceptions.CommandResultError(cwd, cmd, proc.returncode,
                                                 out, err)
 

core/dbt/events/base_types.py

@@ -1,4 +1,4 @@
-from abc import ABCMeta, abstractmethod
+from abc import ABCMeta, abstractmethod, abstractproperty
 from dataclasses import dataclass
 from datetime import datetime
 import os
@@ -58,6 +58,13 @@ class Event(metaclass=ABCMeta):
     ts: Optional[datetime] = None  # use getter for non-optional
     pid: Optional[int] = None  # use getter for non-optional
 
+    # four digit string code that uniquely identifies this type of event
+    # uniqueness and valid characters are enforced by tests
+    @abstractproperty
+    @staticmethod
+    def code() -> str:
+        raise Exception("code() not implemented for event")
+
     # do not define this yourself. inherit it from one of the above level types.
     @abstractmethod
     def level_tag(self) -> str:

core/dbt/events/test_types.py

@@ -15,6 +15,7 @@
 @dataclass
 class IntegrationTestInfo(InfoLevel, Cli):
     msg: str
+    code: str = "T001"
 
     def message(self) -> str:
         return f"Integration Test: {self.msg}"
@@ -23,6 +24,7 @@ def message(self) -> str:
 @dataclass
 class IntegrationTestDebug(DebugLevel, Cli):
     msg: str
+    code: str = "T002"
 
     def message(self) -> str:
         return f"Integration Test: {self.msg}"
@@ -31,6 +33,7 @@ def message(self) -> str:
 @dataclass
 class IntegrationTestWarn(WarnLevel, Cli):
     msg: str
+    code: str = "T003"
 
     def message(self) -> str:
         return f"Integration Test: {self.msg}"
@@ -39,6 +42,7 @@ def message(self) -> str:
 @dataclass
 class IntegrationTestError(ErrorLevel, Cli):
     msg: str
+    code: str = "T004"
 
     def message(self) -> str:
         return f"Integration Test: {self.msg}"
@@ -47,6 +51,7 @@ def message(self) -> str:
 @dataclass
 class IntegrationTestException(ShowException, ErrorLevel, Cli):
     msg: str
+    code: str = "T005"
 
     def message(self) -> str:
         return f"Integration Test: {self.msg}"