Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum req for dbt-common + dbt-adapters #10123

Merged
merged 1 commit into from
May 10, 2024
Merged

Update minimum req for dbt-common + dbt-adapters #10123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
"minimal-snowplow-tracker>=0.0.2,<0.1",
"dbt-semantic-interfaces>=0.5.1,<0.6",
# Minor versions for these are expected to be backwards-compatible
"dbt-common>=1.0.2,<2.0",
"dbt-adapters>=0.1.0a2,<2.0",
"dbt-common>=1.0.4,<2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to set bounds to patch versions, or is minor version sufficient?

For external packages, it looks like we default to pinning to minor version (unless there’s a bug that got fixed in a patch version).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aranke dbt-core==1.8.0 is actually incompatible with dbt-common==1.0.3 and dbt-adapters==1.1.0, due to the __post_serialize__ signature change. I think we need to put the specific patch numbers as the minima here to make clear that incompatibility. It wasn't our proudest semver moment, but we're learning from it and moving forward :)

"dbt-adapters>=1.1.1,<2.0",
# ----
# Expect compatibility with all new versions of these packages, so lower bounds only.
"packaging>20.9",
Expand Down
Loading