-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum req for dbt-common + dbt-adapters #10123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10123 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 181 181
Lines 22786 22786
=======================================
Hits 20096 20096
Misses 2690 2690
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 1 nit
@@ -75,8 +75,8 @@ | |||
"minimal-snowplow-tracker>=0.0.2,<0.1", | |||
"dbt-semantic-interfaces>=0.5.1,<0.6", | |||
# Minor versions for these are expected to be backwards-compatible | |||
"dbt-common>=1.0.2,<2.0", | |||
"dbt-adapters>=0.1.0a2,<2.0", | |||
"dbt-common>=1.0.4,<2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to set bounds to patch versions, or is minor version sufficient?
For external packages, it looks like we default to pinning to minor version (unless there’s a bug that got fixed in a patch version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aranke dbt-core==1.8.0
is actually incompatible with dbt-common==1.0.3
and dbt-adapters==1.1.0
, due to the __post_serialize__
signature change. I think we need to put the specific patch numbers as the minima here to make clear that incompatibility. It wasn't our proudest semver moment, but we're learning from it and moving forward :)
(cherry picked from commit ecf9436)
(cherry picked from commit ecf9436) Co-authored-by: Jeremy Cohen <[email protected]>
prevent #10122 from happening to more people
Problem
If someone has older installs of
dbt-core
+dbt-common
+dbt-adapters
, and theypip install dbt-core
, it won't automatically upgradedbt-common
+dbt-adapters
.But
dbt-core==1.8.0
actually requiresdbt-common>=1.0.4
anddbt-adapters>=1.1.1
, given the change in #10094.Solution
Bump the minimum requirements for
dbt-common
+dbt-adapters
Checklist