Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum req for dbt-common + dbt-adapters #10123

Merged
merged 1 commit into from
May 10, 2024

Conversation

jtcohen6
Copy link
Contributor

prevent #10122 from happening to more people

Problem

If someone has older installs of dbt-core + dbt-common + dbt-adapters, and they pip install dbt-core, it won't automatically upgrade dbt-common + dbt-adapters.

But dbt-core==1.8.0 actually requires dbt-common>=1.0.4 and dbt-adapters>=1.1.1, given the change in #10094.

Solution

Bump the minimum requirements for dbt-common + dbt-adapters

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@jtcohen6 jtcohen6 added the Skip Changelog Skips GHA to check for changelog file label May 10, 2024
@jtcohen6 jtcohen6 requested a review from a team as a code owner May 10, 2024 09:13
@cla-bot cla-bot bot added the cla:yes label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (994a089) to head (af9437d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10123   +/-   ##
=======================================
  Coverage   88.19%   88.19%           
=======================================
  Files         181      181           
  Lines       22786    22786           
=======================================
  Hits        20096    20096           
  Misses       2690     2690           
Flag Coverage Δ
integration 85.45% <ø> (ø)
unit 62.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 nit

@@ -75,8 +75,8 @@
"minimal-snowplow-tracker>=0.0.2,<0.1",
"dbt-semantic-interfaces>=0.5.1,<0.6",
# Minor versions for these are expected to be backwards-compatible
"dbt-common>=1.0.2,<2.0",
"dbt-adapters>=0.1.0a2,<2.0",
"dbt-common>=1.0.4,<2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to set bounds to patch versions, or is minor version sufficient?

For external packages, it looks like we default to pinning to minor version (unless there’s a bug that got fixed in a patch version).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aranke dbt-core==1.8.0 is actually incompatible with dbt-common==1.0.3 and dbt-adapters==1.1.0, due to the __post_serialize__ signature change. I think we need to put the specific patch numbers as the minima here to make clear that incompatibility. It wasn't our proudest semver moment, but we're learning from it and moving forward :)

@jtcohen6 jtcohen6 merged commit ecf9436 into main May 10, 2024
80 checks passed
@jtcohen6 jtcohen6 deleted the jerco/update-min-common-adapters branch May 10, 2024 13:22
github-actions bot pushed a commit that referenced this pull request May 10, 2024
jtcohen6 added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants