Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme install methods #10081

Merged
merged 1 commit into from
May 2, 2024
Merged

update readme install methods #10081

merged 1 commit into from
May 2, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented May 2, 2024

resolves #9699

Problem

Docs mention homebrew as a way to get releases but we no longer support it.

Solution

Link to official docs on install methods so we don't have to keep it up to date

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label May 2, 2024
@emmyoop emmyoop requested a review from a team as a code owner May 2, 2024 14:56
@cla-bot cla-bot bot added the cla:yes label May 2, 2024
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (487a532) to head (b5205c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10081      +/-   ##
==========================================
+ Coverage   88.14%   88.15%   +0.01%     
==========================================
  Files         181      181              
  Lines       22700    22722      +22     
==========================================
+ Hits        20008    20031      +23     
+ Misses       2692     2691       -1     
Flag Coverage Δ
integration 85.47% <ø> (+0.01%) ⬆️
unit 62.37% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop mentioned this pull request May 2, 2024
6 tasks
@emmyoop emmyoop merged commit 8b1f1d5 into main May 2, 2024
66 checks passed
@emmyoop emmyoop deleted the er/remove-homebrew branch May 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KTLO] Remove Homebrew Support
2 participants