Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump torch to <2.4.1 #145

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Bump torch to <2.4.1 #145

merged 8 commits into from
Aug 30, 2024

Conversation

eitanturok
Copy link
Contributor

@eitanturok eitanturok commented Aug 21, 2024

Update: Running the latest tests manually and they pass here

What does this PR do?

  • use "torch >= 2.4.0, < 2.4.1" in setup.py, pyproject.toml
  • use forks of grouped_gemm, stk that support torch2.4
    • will update to official versions of groupped_gemm, stk once they are released
  • use newer version of composer that supports torch2.4
    • will use official version of composer once it is released
  • tests use torch2.4 image

This Github Actions here run the old tests and predictably fail. I manually ran the new Github Actions here and they all pass.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eitanturok eitanturok requested a review from mihir-db August 21, 2024 18:47
@eitanturok eitanturok changed the title bump torch to <2.4.1 (#142) bump torch to <2.4.1 Aug 21, 2024
@eitanturok eitanturok mentioned this pull request Aug 21, 2024
7 tasks
@eitanturok
Copy link
Contributor Author

eitanturok commented Aug 21, 2024

blocked by waiting for new releases of composer, groupped_gemm, stk
resolved

@eitanturok eitanturok marked this pull request as draft August 21, 2024 20:32
@eitanturok eitanturok marked this pull request as ready for review August 26, 2024 18:22
@eitanturok eitanturok requested a review from dakinggg August 26, 2024 18:22
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compsoer version

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Saaketh Narayan <[email protected]>
@eitanturok eitanturok requested a review from snarayan21 August 29, 2024 19:22
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eitanturok
Copy link
Contributor Author

eitanturok commented Aug 29, 2024

Manually ran the tests again and they are failing here

@eitanturok eitanturok marked this pull request as draft August 29, 2024 20:53
@eitanturok eitanturok changed the title bump torch to <2.4.1 [Do not merge] bump torch to <2.4.1 Aug 29, 2024
@eitanturok
Copy link
Contributor Author

eitanturok commented Aug 30, 2024

Running tests manually and the pass here

@eitanturok eitanturok changed the title [Do not merge] bump torch to <2.4.1 Bump torch to <2.4.1 Aug 30, 2024
@eitanturok eitanturok marked this pull request as ready for review August 30, 2024 13:10
@eitanturok eitanturok requested a review from snarayan21 August 30, 2024 13:10
@mihir-db mihir-db merged commit 35abddf into main Aug 30, 2024
3 of 5 checks passed
@mihir-db mihir-db deleted the bump-torch branch August 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants