Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump torch to <2.4.1 #139

Closed
wants to merge 13 commits into from
Closed

Conversation

eitanturok
Copy link
Contributor

What does this PR do?

bump torch to <2.5

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eitanturok eitanturok requested review from mihir-db and dakinggg August 9, 2024 20:50
@eitanturok
Copy link
Contributor Author

TODO: test with torch 2.3 image

@eitanturok
Copy link
Contributor Author

  • megablocks tests run on torch2.3, torch2.4
  • use forks of grouped_gemm, stk that support torch2.4

@eitanturok eitanturok changed the title bump torch to <2.5 bump torch to <2.4.1 Aug 21, 2024
@eitanturok
Copy link
Contributor Author

Closing in favor of #145. That PR is on a different branch of megablocks while this is on a fork of megablocks. It is much easier to run tests from a branch, rather than a fork, of megablocks.

@eitanturok eitanturok closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants