-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Backport schema changes (DEV-3953) #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove __id, __createdAt, __createdBy, __modifiedBy, __modified_At, __deletedAt, __deletedBy properties
* Remove __id property from project * Remove all __createdAt, __createdBy, __modifiedBy, __modified_At, __deletedAt, __deletedBy properties Update the json files, copy over from dsp-meta-svc.
seakayone
changed the title
feat: Backport schema changes
feat!: Backport schema changes
Jul 31, 2024
seakayone
changed the title
feat!: Backport schema changes
feat!: Backport schema changes (DEV-3953)
Jul 31, 2024
BalduinLandolt
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like! Added one suggestion
Merged
This was referenced Aug 2, 2024
This was referenced Sep 3, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update schema-metadata-final.json and schema-metadata-draft.json
__id
property from project__createdAt
,__createdBy
,__modifiedBy
,__modified_At
,__deletedAt
,__deletedBy
properties$schema
Update metadata in
data/json/*.json
to reflect above changesRequire project.status = 'finished' in final schema
Metadata changes by @BalduinLandolt :
Backport of the changes in dasch-swiss/dsp-meta-svc#155
BREAKING as these (formerly partyly required) properties are not returned on the api anymore.