Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Backport schema changes (DEV-3953) #169

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jul 31, 2024

  • Update schema-metadata-final.json and schema-metadata-draft.json

    • Remove __id property from project
    • Remove all __createdAt, __createdBy, __modifiedBy, __modified_At, __deletedAt, __deletedBy properties
    • do not require $schema
  • Update metadata in data/json/*.json to reflect above changes

  • Require project.status = 'finished' in final schema

Metadata changes by @BalduinLandolt :

  • Finalized delille project

Backport of the changes in dasch-swiss/dsp-meta-svc#155

BREAKING as these (formerly partyly required) properties are not returned on the api anymore.

* Remove __id, __createdAt, __createdBy, __modifiedBy, __modified_At, __deletedAt, __deletedBy properties
* Remove __id property from project
* Remove all __createdAt, __createdBy, __modifiedBy, __modified_At, __deletedAt, __deletedBy properties

Update the json files, copy over from dsp-meta-svc.
@seakayone seakayone changed the title feat: Backport schema changes feat!: Backport schema changes Jul 31, 2024
@seakayone seakayone changed the title feat!: Backport schema changes feat!: Backport schema changes (DEV-3953) Jul 31, 2024
Copy link

linear bot commented Jul 31, 2024

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like! Added one suggestion

data/json/Rome.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants