Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean up unused code and merge creates DEV-4067 #200

Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Sep 3, 2024

  • Remove unused code:
    -- All code related to file formats other than json
    -- Experimental rdf code which is not used in the server or cli
    -- Unused domain model code
  • Merge crates and remove Cargo workspace
  • Delete unused dependencies
  • Update Cargo.lock
  • Update release-please config and manifest

Copy link

linear bot commented Sep 3, 2024

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.5%. Comparing base (4d3820f) to head (70848d3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/main-server.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/api/convert/axum/responses.rs 0.0% <ø> (ø)
src/api/handler/health.rs 100.0% <ø> (ø)
src/api/handler/robots_txt.rs 100.0% <ø> (ø)
src/api/handler/sitemap_xml.rs 100.0% <ø> (ø)
src/api/handler/v1/projects/handlers.rs 100.0% <ø> (ø)
src/api/handler/v1/projects/responses.rs 100.0% <ø> (ø)
src/api/router.rs 99.1% <100.0%> (ø)
src/cli.rs 0.0% <ø> (ø)
src/domain/metadata_repository.rs 90.1% <100.0%> (ø)
src/domain/metadata_service.rs 100.0% <ø> (ø)
... and 7 more

@seakayone seakayone marked this pull request as ready for review September 3, 2024 10:00
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments in the Cargo.toml file, other than that it looks good

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
seakayone and others added 3 commits September 3, 2024 13:10
Co-authored-by: Balduin Landolt <[email protected]>
Co-authored-by: Balduin Landolt <[email protected]>
.github/release-please/manifest.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants