-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Remove redundant internal properties from metadata and schema (DEV-3929) #155
chore: Remove redundant internal properties from metadata and schema (DEV-3929) #155
Conversation
…ttps://github.com/dasch-swiss/dsp-meta-svc into feature/dev-3929-remove-unnecessary-__xx-properties
@BalduinLandolt Only one question, why in this repo and not in dsp-meta? As far as I understand it, this repo will never be published again. |
We're keeping this the source of truth until the new version is on prod. Moving these changes over to the new repo literally only takes a couple of seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: When removing the ids we cannot reference the data anymore.
I would like to keep the __id
for most of out data so these can be referenced in future.
Also some Data is already reference within the data model, e.g. Person, Dataset ....
I only removed IDs for project, where they are not referenced anywhere |
Yet... And maybe never will? Unless we decide to add linked data support again. question Are there planned updated to the json data? The problem with integrating your PR first is that we then cannot simply copy over the data but will have to change code in the new service, are you planning on backporting it to the dsp-meta? I am ok with your changes but it potentially leads to a bit of a confusion. All depends on when we do the GoLive. |
If you look at the project IDs, they were only dependent on the shortcode which we still have (except for the rome project, where I'm not sure why the ID was changed, but it should not have happened), so in the future we can still add those IDs if we want, or generate them on the fly as needed.
Sorry, I'm not sure I understand the question.
Yes, I will of course adapt the BE to backport this (if it gets merged)
I will wait with this until the GoLive is through, so we can be sure to avoid confusion. |
AFAIU we will need the projects IDs for the "RDF and FAIR data assessment" project eventually. These ids should stay the same as they currently are I would suppose. I feel like we need a stronger reason to remove them than just "because". Am I missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: project.__id
will be needed once we serve Linked Data
The values of the __id
property is not always derived from the shortcode.
For example the Rome.json
contains "__id": "http://ns.dasch.swiss/repository#dsp-REMA-project"
. This may be a mistake in the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the id of the project should always contain the shortcode. @BalduinLandolt will clarify for Rome.json how to proceed.
DEV-3929