-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyPath/copyPathSync: expose parameter followLinks
#1267
base: main
Are you sure you want to change the base?
Conversation
FYI: @natebosch |
@jakemac53 I think uses are unlike to break if we change the default behavior. We already have a default behavior for |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
The current behavior is I vote to keep the current behavior as the default since this is a core function and could be used by multiple third-party projects that might not catch any changes in this behavior in their tests, as it's not a common thing to test. The main purpose is to add an extra option for those who really want to change the behavior. |
Directory.listSync only returns Link entries if followLinks: false is passed.
copyPath needs a followLinks parameter to configure the call of Directory.listSync and allow the copy of Link entries, as expected by line else if (file is Link) {