This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
copyPath: add parameter followLinks #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Directory.listSync` only returns `Link` entries if `followLinks: false` is passed. `copyPath` needs a `followLinks` parameter to configure the call of `Directory.listSync` and allow the copy of `Link` entries, as expected by line `else if (file is Link) {`
|
Can you add a test and a CHANGELOG entry? |
👍 |
devoncarew
added
the
needs-info
|
Thanks for the example - can we find a way to test this in the local unit tests? We also still need a CHANGELOG entry. https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#changelog-entries |
github-actions
bot
removed
the
needs-info
I will try this in the next week. Regards. |
|
Still need an unit test? |
Yes - if we break this functionality there should be some local test which signals the problem. |
|
Closing as the dart-lang/io repository is merged into the dart-lang/tools monorepo. Please re-open this PR there! |
|
Re-opened at: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory.listSynconly returnsLinkentries iffollowLinks: falseis passed.copyPathneeds afollowLinksparameter to configure the call ofDirectory.listSyncand allow the copy ofLinkentries, as expected by lineelse if (file is Link) {