-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sticky header js and styling #244
Merged
spaceo
merged 5 commits into
danskernesdigitalebibliotek:develop
from
reload:DDFDPDEL-215-semi-sticky-headers-pa-mobil
Aug 31, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f817ac4
Adding sticky header js and styling
spaceo 040b768
Update src/stories/Blocks/header/header-sticky.js
spaceo 8a514df
Remove deprecated up/down classes
spaceo 5d699e1
Introducing z-index variables
spaceo bb11fc1
Generalised the conf of `updateStickyHeader()`
spaceo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
window.addEventListener("DOMContentLoaded", () => { | ||
spaceo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
let scrollDirection = "up"; | ||
let lastScrollY = window.scrollY; | ||
const headerOffsetTop = document.querySelector("header").offsetTop; | ||
|
||
const updateStickyHeader = ({ | ||
// If you want to set a custom starting position for the header. | ||
initialHeaderYposition = null, | ||
// Tweak the header position when it's down by this amount. | ||
headerDownTopPositionOffset = 5, | ||
// Wait this many pixels before showing/hiding the header. | ||
waitPx = 5, | ||
}) => { | ||
// Get the starting position of the header | ||
const headerYStartPosition = initialHeaderYposition ?? headerOffsetTop; | ||
|
||
const { scrollY } = window; | ||
// Detect if we are going up or down. | ||
const direction = scrollY > lastScrollY ? "down" : "up"; | ||
if ( | ||
direction !== scrollDirection && | ||
Math.abs(scrollY - lastScrollY) > waitPx | ||
) { | ||
scrollDirection = direction; | ||
} | ||
lastScrollY = scrollY > 0 ? scrollY : 0; | ||
|
||
// Control header direction class. | ||
if (scrollDirection === "down") { | ||
const headerHeight = document.querySelector("header").offsetHeight; | ||
const headerDownTopPosition = headerHeight + headerDownTopPositionOffset; | ||
document.querySelector( | ||
"header" | ||
).style.top = `-${headerDownTopPosition}px`; | ||
} else { | ||
document.querySelector("header").style.top = `${headerYStartPosition}px`; | ||
} | ||
}; | ||
|
||
window.addEventListener("scroll", updateStickyHeader); | ||
}); |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
$-z-10: -10; | ||
$-z-5: -5; | ||
$z-5: 5; | ||
$z-10: 10; | ||
$z-15: 15; | ||
$z-20: 20; | ||
$z-25: 25; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 excellent.