Adding sticky header js and styling #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceo
force-pushed
the
DDFDPDEL-215-semi-sticky-headers-pa-mobil
branch
from
5087f8a
to
f817ac4
Compare
3 tasks
Adamik10
approved these changes
Aug 29, 2023
kasperg
approved these changes
Aug 31, 2023
Comment on lines
+40
to
+44
| <p className="my-16"> | ||
| <strong> | ||
| Because of limitations regarding determing y position and scroll in an | ||
| iframe open the frame to see the sticky header in action | ||
| </strong> |
Co-authored-by: Kasper Garnæs <[email protected]>
Since we manipulate with the style attribute of the header directly
spaceo
force-pushed
the
DDFDPDEL-215-semi-sticky-headers-pa-mobil
branch
from
068095b
to
6c56c89
Compare
We need to handle the z-index layers in a controlled manner so we use the same concept as we use for spacing with fixed values.
spaceo
force-pushed
the
DDFDPDEL-215-semi-sticky-headers-pa-mobil
branch
from
6c56c89
to
bb11fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFDPDEL-215
Description
Adds sticky header feature to the header.
See it in action
https://616ffdab9acbf5003ad5fd2b-kemehffrpc.chromatic.com/iframe.html?args=&id=blocks-header--sticky-header-with-content&viewMode=story
Checklist