-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] display beta warning and decorator info #26821
base: maxime/ad-758/add-preview-docs
Are you sure you want to change the base?
[docs] display beta warning and decorator info #26821
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-7w4aq188v-elementl.vercel.app Direct link to changed pages: |
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-32ir2hfh9-elementl.vercel.app Direct link to changed pages: |
@maximearmstrong do we need to make any changes for the new docs as well? For example, I recall association a color, Which is then styled in the CSS here: https://github.com/dagster-io/dagster/blob/master/docs/docs-beta/src/styles/custom.scss#L622-L653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
I left a comment regarding the styling for Docusaurus, which we can address in a follow-up PR (if not already addressed).
2470b5e
to
2b8ada1
Compare
f9dda64
to
208deae
Compare
Summary & Motivation
Same as #25362 but for the new beta decorator introduced in #26748