Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] display beta warning and decorator info #26821

Open
wants to merge 1 commit into
base: maxime/ad-758/add-preview-docs
Choose a base branch
from

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jan 3, 2025

Summary & Motivation

Same as #25362 but for the new beta decorator introduced in #26748

Copy link
Contributor Author

maximearmstrong commented Jan 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 3, 2025

Copy link

github-actions bot commented Jan 3, 2025

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-32ir2hfh9-elementl.vercel.app

Direct link to changed pages:

@cmpadden
Copy link
Contributor

cmpadden commented Jan 6, 2025

@maximearmstrong do we need to make any changes for the new docs as well? For example, I recall association a color, experimental -> warning in the MDX builder here:

https://github.com/dagster-io/dagster/blob/master/docs/sphinx/_ext/sphinx-mdx-builder/sphinxcontrib/mdxbuilder/writers/mdx.py#L950

Which is then styled in the CSS here:

https://github.com/dagster-io/dagster/blob/master/docs/docs-beta/src/styles/custom.scss#L622-L653

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

I left a comment regarding the styling for Docusaurus, which we can address in a follow-up PR (if not already addressed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants