[docs] display preview warning and decorator info #26819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-rictiq58e-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
requested review from
PedramNavid,
salazarm,
yuhan,
cmpadden and
OwenKephart
maximearmstrong
commented
Jan 3, 2025
| @@ -104,6 +104,10 @@ dt > a.reference.internal { | |||
| @apply inline-flex items-center px-3 py-0.5 rounded-full align-middle text-xs uppercase font-medium bg-sea-foam text-gable-green | |||
| } | |||
|
|
|||
| .preview-tag { | |||
There was a problem hiding this comment.
Do we also need a .preview-tag.flag.preview for the API docs? Looking at superseded and deprecated, we have two different CSS per flag, but it's not the case for experimental.
There was a problem hiding this comment.
That CSS hasn't been touched in quite some time, but it looks like @hellendag was the one to do it. Perhaps he would know. 🤔
maximearmstrong
force-pushed
the
maxime/ad-758/add-preview-docs
branch
from
2470b5e to
2b8ada1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Same as #25362 but for the new preview decorator introduced in #26747