Fix helm #26752
Merged
Fix helm #26752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
pr's bk seems still broken |
dpeng817
force-pushed
the
dpeng817/fix_helm
branch
from
0066741 to
fd6d4b5
Compare
|
@yuhan should be fixed now (just needed to reorder schema) |
gibsondan
approved these changes
Dec 30, 2024
|
@dpeng817 note that there is a CLI command that you need to run (dagster-helm schema apply) for tests to pass before landing to regenerate the JSON schema |
dpeng817
force-pushed
the
dpeng817/fix_helm
branch
from
fd6d4b5 to
8312033
Compare
dpeng817
force-pushed
the
dpeng817/fix_helm
branch
from
8312033 to
8c5072c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Didn't forward the new prop to helm. This fixes
How I Tested These Changes
Previously failing tests now pass on local