Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clap feature for reporting deprecation #42

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

koxu1996
Copy link
Contributor

There is interesting clap's optional feature that we should enable:

  • deprecated: Guided experience to prepare for next breaking release (at different stages of development, this may become default)

This would trigger the warnings like this reported in #37:

warning: use of deprecated function `<common::args::AmountArg as clap::Args>::augment_args::id_is_only_for_arg`: `#[arg(name)] was allowed by mistake, instead use `#[arg(id
)]` or `#[arg(value_name)]`

@koxu1996 koxu1996 merged commit dc4b1bb into main Mar 19, 2024
6 checks passed
@koxu1996 koxu1996 deleted the feature/enable-clap-deprecated-warnings branch March 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants