Fix use of deprecated function in kairos-cli

[marijanp]

kairos> warning: use of deprecated function `<common::args::AmountArg as clap::Args>::augment_args::id_is_only_for_arg`: `#[arg(name)] was allowed by mistake, instead use `#[arg(id
)]` or `#[arg(value_name)]`                                                                                                                                                         
kairos>  --> kairos-cli/src/common/args.rs:7:11                                                                                                                                     
kairos>   |                                                                                                                                                                         
kairos> 7 |     #[arg(name = "amount", long, short, value_name = "NUM_MOTES")]                                                                                                      
kairos>   |           ^^^^                                                                                                                                                          
kairos>   |                                                                                                                                                                         
kairos>   = note: `#[warn(deprecated)]` on by default                                                                                                                               
kairos> warning: use of deprecated function `<common::args::PrivateKeyPathArg as clap::Args>::augment_args::id_is_only_for_arg`: `#[arg(name)] was allowed by mistake, instead use `
#[arg(id)]` or `#[arg(value_name)]`                                                                                                                                                 
kairos>   --> kairos-cli/src/common/args.rs:13:11                                                                                                                                   
kairos>    |                                                                                                                                                                        
kairos> 13 |     #[arg(name = "private-key", long, short = 'k', value_name = "FILE_PATH")]                                                                                          
kairos>    |           ^^^^                                                                      

[koxu1996]

Not reproducible locally, neither in CI/CD.

[marijanp]

@koxu1996 It will when using future clap versions. This PR's pipeline will not pass without these changes: #34 (comment)

And I decided to submit this commit through a separate PR

[koxu1996]

Future clap version (4.5.3) was already used on main branch, and there was no warning.

[marijanp]

Ok I will investigate it and prove

[marijanp]

Semantic versions don't provide confidence whether sources might have changed. So you could have different sources for a package with the same semantic version.

Here is the code that causes these warnings: https://github.com/clap-rs/clap/blob/4e07b438584bb8a19e37599d4c5b11797bec5579/clap_derive/src/item.rs#L317

[koxu1996]

Thank you! I am just trying to understand what happened here, to avoid such undetected warnings in the future.

[koxu1996]

Here is the code that causes these warnings: https://github.com/clap-rs/clap/blob/4e07b438584bb8a19e37599d4c5b11797bec5579/clap_derive/src/item.rs#L317

@marijanp Deprecation was introduced in February 2022 and seems to be released in older versions of clap as well.

I guess you just executed some extra commands/checks, and if so, we should have them included in CI/CD.

[marijanp]

I can create a CI run which removes the changes in the PR and prove that the audit fails. I can't find the core reason that triggers this depreciation warning.

[koxu1996]

@marijanp Please go ahead, I am pretty sure audit will succeed.

Btw. I solved the mystery 🎉. To get this warning you have to enable extra feature flag - please see #42.