Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kairos test utils #34

Merged
merged 17 commits into from
Mar 26, 2024
Merged

Add kairos test utils #34

merged 17 commits into from
Mar 26, 2024

Conversation

marijanp
Copy link
Contributor

No description provided.

@marijanp marijanp linked an issue Mar 11, 2024 that may be closed by this pull request
create cctl test hook #20
Closed
5 tasks
@marijanp marijanp self-assigned this Mar 11, 2024
@marijanp marijanp force-pushed the add-kairos-test-utils branch 2 times, most recently from 17d3d97 to a6e0940 Compare March 17, 2024 21:56
@marijanp marijanp marked this pull request as ready for review March 17, 2024 23:47
Avi-D-coder
Avi-D-coder reviewed Mar 18, 2024
View reviewed changes
kairos-test-utils/Cargo.toml Outdated
Comment on lines 11 to 13
log = "*"
tokio = { version = "*", features = [ "full", "macros" ] }
env_logger = "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to uniformly use tracing over log/env_logger.
This can be changed in a followup eventually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced log with tracing

marijanp
marijanp commented Mar 18, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
@marijanp marijanp mentioned this pull request Mar 18, 2024
Closed
@marijanp marijanp force-pushed the add-kairos-test-utils branch 2 times, most recently from 071e411 to 9a0d1c4 Compare March 18, 2024 21:06
@marijanp marijanp requested a review from Avi-D-coder March 18, 2024 21:50
@asladeofgreen
Copy link
Member

asladeofgreen commented Mar 18, 2024 •
edited
Loading

General comment: as stated via Zulip DM we could factor out this work into a dedicated cctl-rs library within the casper-network GH space. To be discussed in more detail a little further down the road.

@marijanp marijanp force-pushed the add-kairos-test-utils branch from 9a0d1c4 to f9ef151 Compare March 19, 2024 14:03
koxu1996
koxu1996 reviewed Mar 20, 2024
View reviewed changes
kairos-server/Cargo.toml
@@ -18,7 +18,6 @@ axum-extra = { version = "0.9", features = [
"typed-header",
"json-deserializer",
] }
thiserror = "1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it as it is.

@koxu1996
Copy link
Contributor

@marijanp Looks good, few minor improvements to be done. I think it should be noted that this test util has implicit bash dependency.

@marijanp marijanp force-pushed the add-kairos-test-utils branch from f9ef151 to acd3035 Compare March 20, 2024 17:36
@marijanp marijanp requested a review from koxu1996 March 20, 2024 17:42
@marijanp marijanp force-pushed the add-kairos-test-utils branch from acd3035 to 4e3697e Compare March 20, 2024 18:52
@marijanp marijanp added the demo Required for our first demo label Mar 21, 2024
koxu1996
koxu1996 reviewed Mar 25, 2024
View reviewed changes
kairos-tx/Cargo.toml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes should not be part of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are minor, in a separate commit and replicating work that Avi did in last weeks toolchain update PR

@marijanp marijanp merged commit 5fd9c57 into main Mar 26, 2024
6 checks passed
@marijanp marijanp deleted the add-kairos-test-utils branch March 26, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-D-coder Avi-D-coder Avi-D-coder approved these changes

@koxu1996 koxu1996 koxu1996 approved these changes

@Rom3dius Rom3dius Awaiting requested review from Rom3dius

@jonas089 jonas089 Awaiting requested review from jonas089

Assignees

@marijanp marijanp

Labels
demo Required for our first demo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create cctl test hook
4 participants
@marijanp @asladeofgreen @koxu1996 @Avi-D-coder