Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omar dev Assignment3 #33

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 36 additions & 28 deletions ex01.exs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

defmodule Ex01 do

@moduledoc """
Expand Down Expand Up @@ -26,11 +25,26 @@ defmodule Ex01 do
2 is the program well laid out, appropriately using indentation,
blank lines, vertical alignment
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 + 10

def counter(value \\ 0) do
receive do
{:next, from} ->
send from, {:next_is, value}
counter(value + 1)
end
end

end
def new_counter(start_value) do
spawn __MODULE__, :counter, [start_value]
end

def next_value(counter_pid) do
send counter_pid, {:next, self}
receive do
{:next_is, value} -> value
end
end
end

ExUnit.start()

Expand All @@ -41,35 +55,29 @@ defmodule Test do
# This test assumes you have a function `counter` that can be spawned
# and which handles the `{:next, from}` message

# test "basic message interface" do
# count = spawn Ex01, :counter, []
# send count, { :next, self }
# receive do
# { :next_is, value } ->
# assert value == 0
# end
#
# send count, { :next, self }
# receive do
# { :next_is, value } ->
# assert value == 1
# end
# end
test "basic message interface" do
count = spawn Ex01, :counter, []
send count, { :next, self }
receive do
{ :next_is, value } ->
assert value == 0
end

send count, { :next, self }
receive do
{ :next_is, value } ->
assert value == 1
end
end

# then uncomment this one
# Now we add two new functions to Ex01 that wrap the use of
# that counter function, making the overall API cleaner

# test "higher level API interface" do
# count = Ex01.new_counter(5)
# assert Ex01.next_value(count) == 5
# assert Ex01.next_value(count) == 6
# end
test "higher level API interface" do
count = Ex01.new_counter(5)
assert Ex01.next_value(count) == 5
assert Ex01.next_value(count) == 6
end

end






66 changes: 39 additions & 27 deletions ex02.exs
Original file line number Diff line number Diff line change
@@ -1,6 +1,24 @@

defmodule Ex02 do

@name __MODULE__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-4

You have a couple of "unused variable" warnings here.

You need to clear these up before submitting.


def new_counter(start_value \\ 0) do
{:ok, counter} = Agent.start_link(fn-> start_value end)
end

def next_value({ :ok, counter }) do
Agent.get_and_update(counter, &{&1, (&1+1) } )
end

def new_global_counter(start_value \\ 0) do
{:ok, counter} = Agent.start_link(fn -> start_value end, name: @name)
end

def global_next_value do
Agent.get_and_update(@name, &{&1, (&1+1) } )
end

end

ExUnit.start()
Expand All @@ -23,7 +41,7 @@ defmodule Test do
2 is the program well laid out, appropriately using indentation,
blank lines, vertical alignment
"""


@doc """
First uncomment this test. Here you will be inserting code
Expand All @@ -32,26 +50,26 @@ defmodule Test do
Replace the placeholders with your code.
"""

# test "counter using an agent" do
# { :ok, counter } = « your code »
#
# value = « your code »
# assert value == 0
#
# value = « your code »
# assert value == 1
# end
test "counter using an agent" do
{ :ok, counter } = Agent.start(fn -> 0 end)

value = Agent.get_and_update(counter, &{&1, (&1 +1) } )
assert value == 0

value = Agent.get_and_update(counter, &{&1, (&1 +1) } )
assert value == 1
end

@doc """
Next, uncomment this test, and add code to the Ex02 module at the
top of this file to make those tests run.
"""

# test "higher level API interface" do
# count = Ex02.new_counter(5)
# assert Ex02.next_value(count) == 5
# assert Ex02.next_value(count) == 6
# end
test "higher level API interface" do
count = Ex02.new_counter(5)
assert Ex02.next_value(count) == 5
assert Ex02.next_value(count) == 6
end

@doc """
Last (for this exercise), we'll create a global counter by adding
Expand All @@ -60,16 +78,10 @@ defmodule Test do
that agent into calls to `global_next_value`?
"""

# test "global counter" do
# Ex02.new_global_counter
# assert Ex02.global_next_value == 0
# assert Ex02.global_next_value == 1
# assert Ex02.global_next_value == 2
# end
test "global counter" do
Ex02.new_global_counter
assert Ex02.global_next_value == 0
assert Ex02.global_next_value == 1
assert Ex02.global_next_value == 2
end
end






21 changes: 18 additions & 3 deletions ex03.exs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ defmodule Ex03 do
5 does it produce the correct results on any valid data

Tested
if tests are provided as part of the assignment:
if tests are provided as part of the assignment:
5 all pass

Aesthetics
Expand All @@ -60,7 +60,22 @@ defmodule Ex03 do
"""

def pmap(collection, process_count, function) do
« your code here »

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30

(although I'd rather not have the pipeline with comments and blank lines in it—for some reason the convention is that they should all be adjacent.

# calculate number of chunks
num_chunks = collection |> Enum.count |> div(process_count)

# split collection into n chunks
collection |> Enum.chunk(num_chunks, num_chunks, [])

# process chunks
|> Enum.map(&Task.async(fn -> Enum.map(&1, function) end))

# wait for all the chunks to get processed
|> Enum.map(&Task.await/1)

# put chunks back together
|> Enum.concat

end

end
Expand Down Expand Up @@ -96,5 +111,5 @@ defmodule TestEx03 do
assert result2 == result1
assert time2 < time1 * 0.8
end

end