Omar dev Assignment3 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to give the step if you also need the 4th parameter. |
pragdave
reviewed
Oct 15, 2016
| @@ -26,11 +25,26 @@ defmodule Ex01 do | |||
| 2 is the program well laid out, appropriately using indentation, | |||
| blank lines, vertical alignment | |||
| """ | |||
|
|
|||
| @@ -1,6 +1,24 @@ | |||
|
|
|||
| defmodule Ex02 do | |||
|
|
|||
| @name __MODULE__ | |||
There was a problem hiding this comment.
-4
You have a couple of "unused variable" warnings here.
You need to clear these up before submitting.
| @@ -60,7 +60,22 @@ defmodule Ex03 do | |||
| """ | |||
|
|
|||
| def pmap(collection, process_count, function) do | |||
| « your code here » | |||
|
|
|||
There was a problem hiding this comment.
30
(although I'd rather not have the pipeline with comments and blank lines in it—for some reason the convention is that they should all be adjacent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: Enum.chunk(num_chunks, num_chunks, [])
According to http://elixir-lang.org/docs/stable/elixir/Enum.html#chunk_by/2,
chunk(enumerable, count, step, leftover \ nil) step is optional, and defaults to count if not passed.
I tried to do Enum.chunk(num_chunks) but it didn't work.
Any idea why that is?