-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oglesbee A3 #30
base: master
Are you sure you want to change the base?
Oglesbee A3 #30
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,26 @@ | ||
|
||
defmodule Ex02 do | ||
|
||
@global_counter Ex02 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 10*3 |
||
|
||
def new_global_counter(value \\ 0) do | ||
{:ok, counter} = Agent.start_link(fn -> value end, name: @global_counter) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically, you don't have to return the |
||
counter | ||
end | ||
|
||
def global_next_value do | ||
Agent.get_and_update(@global_counter, fn state -> {state, state+1} end) | ||
end | ||
|
||
def new_counter(value \\ 0) do | ||
{ :ok, counter } = Agent.start_link(fn -> value end) | ||
counter | ||
end | ||
|
||
def next_value(counter) do | ||
Agent.get_and_update(counter, fn state -> {state, state + 1} end) | ||
end | ||
|
||
end | ||
|
||
ExUnit.start() | ||
|
@@ -23,7 +43,6 @@ defmodule Test do | |
2 is the program well laid out, appropriately using indentation, | ||
blank lines, vertical alignment | ||
""" | ||
|
||
|
||
@doc """ | ||
First uncomment this test. Here you will be inserting code | ||
|
@@ -32,26 +51,26 @@ defmodule Test do | |
Replace the placeholders with your code. | ||
""" | ||
|
||
# test "counter using an agent" do | ||
# { :ok, counter } = « your code » | ||
# | ||
# value = « your code » | ||
# assert value == 0 | ||
# | ||
# value = « your code » | ||
# assert value == 1 | ||
# end | ||
test "counter using an agent" do | ||
{ :ok, counter } = Agent.start_link(fn -> 0 end) | ||
|
||
value = Agent.get_and_update(counter, fn state -> {state, state+1} end) | ||
assert value == 0 | ||
|
||
value = Agent.get_and_update(counter, fn state -> {state, state+1} end) | ||
assert value == 1 | ||
end | ||
|
||
@doc """ | ||
Next, uncomment this test, and add code to the Ex02 module at the | ||
top of this file to make those tests run. | ||
""" | ||
|
||
# test "higher level API interface" do | ||
# count = Ex02.new_counter(5) | ||
# assert Ex02.next_value(count) == 5 | ||
# assert Ex02.next_value(count) == 6 | ||
# end | ||
test "higher level API interface" do | ||
count = Ex02.new_counter(5) | ||
assert Ex02.next_value(count) == 5 | ||
assert Ex02.next_value(count) == 6 | ||
end | ||
|
||
@doc """ | ||
Last (for this exercise), we'll create a global counter by adding | ||
|
@@ -60,12 +79,12 @@ defmodule Test do | |
that agent into calls to `global_next_value`? | ||
""" | ||
|
||
# test "global counter" do | ||
# Ex02.new_global_counter | ||
# assert Ex02.global_next_value == 0 | ||
# assert Ex02.global_next_value == 1 | ||
# assert Ex02.global_next_value == 2 | ||
# end | ||
test "global counter" do | ||
Ex02.new_global_counter | ||
assert Ex02.global_next_value == 0 | ||
assert Ex02.global_next_value == 1 | ||
assert Ex02.global_next_value == 2 | ||
end | ||
end | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,7 +60,18 @@ defmodule Ex03 do | |
""" | ||
|
||
def pmap(collection, process_count, function) do | ||
« your code here » | ||
# The max process count is one process per item in the collection | ||
# (Not very efficient, but it will work) | ||
safe_process_count = min(Enum.count(collection), process_count) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see what you're doing, but the spec explicitly says to divide the collection into n chunks, where n is the number of processors. -5 |
||
|
||
collection | ||
# Split into even chunks, being sure to handle leftovers | ||
|> Enum.chunk(safe_process_count, safe_process_count, []) | ||
# Create a seperate map task for each chunk | ||
|> Enum.map(&Task.async(fn -> Enum.map(&1, function) end)) | ||
# Await the results... | ||
|> Enum.map(&Task.await(&1)) | ||
|> Enum.concat | ||
end | ||
|
||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10, 10