Oglesbee A3 #30
Open
Oglesbee A3 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragdave
reviewed
Oct 15, 2016
| @@ -28,6 +28,22 @@ defmodule Ex01 do | |||
| """ | |||
|
|
|||
| def counter(value \\ 0) do | |||
| receive do | |||
| @global_counter Ex02 | ||
|
|
||
| def new_global_counter(value \\ 0) do | ||
| {:ok, counter} = Agent.start_link(fn -> value end, name: @global_counter) |
There was a problem hiding this comment.
Technically, you don't have to return the counter pid here, but it doesn't hurt.
| @@ -1,6 +1,26 @@ | |||
|
|
|||
| defmodule Ex02 do | |||
|
|
|||
| @global_counter Ex02 | |||
| « your code here » | ||
| # The max process count is one process per item in the collection | ||
| # (Not very efficient, but it will work) | ||
| safe_process_count = min(Enum.count(collection), process_count) |
There was a problem hiding this comment.
I see what you're doing, but the spec explicitly says to divide the collection into n chunks, where n is the number of processors.
-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luke Oglesbee
38953581
Cheers!