memory-layout/memory-operations-and-GDB: Add reading and tasks #5

dumitrache-adrian92 · 2024-03-01T14:51:58Z

Prerequisite Checklist

Read the contribution guidelines regarding submitting new changes to the project;
Tested your changes against relevant architectures and platforms;
Updated relevant documentation (if needed).

Description of changes

Add reading and tasks for lab 2 and modify config.yaml to render the new content.

chapters/memory-layout/memory-operations/reading/README.md

github-actions · 2024-03-02T20:14:00Z

Published at https://cs-pub-ro.github.io/hardware-software-interface/5/

github-actions · 2024-03-02T20:59:20Z

Published at https://cs-pub-ro.github.io/hardware-software-interface/5/

teodutu

I only gave a bird's eye view on this PR. I'll look into more depth and check the content more thoroughly after you address my high-level comments. In addition to my inline comments, do the following:

Go through the linter errors and fix them [1] and especially [2].
Add the following line at the end of each exercise: "If you're having difficulties solving this exercise, go through [this](link to a relevant reading section) reading material"
Translate all code comments to English and use convert them to C-style: /* ... */ or /** ... */ for multiline comments.

[1] https://github.com/cs-pub-ro/hardware-software-interface/actions/runs/8125357327/job/22207876189?pr=5
[2] https://github.com/cs-pub-ro/hardware-software-interface/actions/runs/8125357327/job/22207876129?pr=5

chapters/memory-layout/introduction-to-GDB/drills/tasks/inspect/README.md

chapters/memory-layout/introduction-to-GDB/drills/tasks/segfault/support/.gitignore

chapters/memory-layout/introduction-to-GDB/drills/tasks/inspect/support/inspect.c

chapters/memory-layout/introduction-to-GDB/drills/tasks/inspect/README.md

chapters/memory-layout/memory-operations/drills/tasks/pixels/solution/pixel.h

chapters/memory-layout/memory-operations/drills/tasks/pixels/solution/pixels.c

chapters/memory-layout/memory-operations/drills/tasks/pixels/solution/pixel.h

chapters/memory-layout/memory-operations/drills/tasks/pixels/support/pixel.h

github-actions · 2024-03-03T00:12:09Z

Published at https://cs-pub-ro.github.io/hardware-software-interface/5/

dumitrache-adrian92 · 2024-03-03T00:24:59Z

Still need to add advice for each problem, I'll come back to this later. Everything else is done (I think).

chapters/memory-layout/introduction-to-GDB/drills/tasks/inspect/support/.gitignore

chapters/memory-layout/introduction-to-GDB/guides/segfault/README.md

chapters/memory-layout/introduction-to-GDB/reading/README.md

Dave080302 · 2024-03-03T00:42:56Z

chapters/memory-layout/memory-operations/drills/tasks/delete_first/README.md

For this exercise I would suggest restricting the use of functions from string.h, we should teach them about memcpy and memcmp here, since they're gonna be working with them exclusively in the homework anyways.

Interesting, I'll look into doing this tonight.

chapters/memory-layout/memory-operations/reading/README.md

chapters/memory-layout/introduction-to-GDB/reading/README.md

dumitrache-adrian92 · 2024-03-03T17:21:50Z

I added all the proposed changes except the rework of the delete_first exercise proposed by Dave. I want to hear everyone's opinions on how it should be approached (and if everyone agrees with it).

As I see it we'd probably need to add another subsection to the reading page that describes the memcmp, memcpy, etc. functions, making the already long reading section even longer. Thoughts?

github-actions · 2024-03-03T17:24:16Z

Published at https://cs-pub-ro.github.io/hardware-software-interface/5/

teodutu

This is looking much better than before. I only made some cosmetic comments to make super-linter pass [1]. The checkpatch failure is a false positive, so don't worry about it. The spellcheck failure should be fixed when you git push -f since I added the missing words to the wordlist [2].

[1] https://github.com/cs-pub-ro/hardware-software-interface/actions/runs/8131747551/job/22221428017?pr=5#step:3:698
[2] open-education-hub/actions#44

teodutu · 2024-03-04T19:17:18Z

chapters/memory-layout/memory-operations/drills/tasks/pointers/README.md

+Implement the functions [memcpy](http://www.cplusplus.com/reference/cstring/memcpy/), [strcpy](http://www.cplusplus.com/reference/cstring/strcpy/), and [strcmp](http://www.cplusplus.com/reference/cstring/strcmp/) using pointer operations.
+
+If you're having difficulties solving this exercise, go through [this](../../../reading/README.md#pointer-operations-and-pointer-arithmetic) reading material.
+


Suggested change

There are 2 blank lines here, that's the problem.

chapters/memory-layout/introduction-to-GDB/reading/README.md

teodutu · 2024-03-04T20:56:39Z

chapters/memory-layout/memory-operations/drills/tasks/pixels/support/pixel.h

+
+	for (int i = 0; i < height; ++i)
+		for (int j = 0; j < width; ++j)
+			pix_array[i][j] = generate_pixel(rand() % 256,


Suggested change

pix_array[i][j] = generate_pixel(rand() % 256,

pix_array[i][j] = generate_pixel(rand() % 256,

Use rand_r() instead of rand() as suggested by super-linter: https://github.com/cs-pub-ro/hardware-software-interface/actions/runs/8131747551/job/22221428017?pr=5#step:3:698

Replace rand() with rand_r().

teodutu

You forgot to address 2 of my previous comments. Maybe you forgot to git add those files?

teodutu · 2024-03-05T14:30:25Z

chapters/memory-layout/memory-operations/drills/tasks/pointers/README.md

+Implement the functions [memcpy](http://www.cplusplus.com/reference/cstring/memcpy/), [strcpy](http://www.cplusplus.com/reference/cstring/strcpy/), and [strcmp](http://www.cplusplus.com/reference/cstring/strcmp/) using pointer operations.
+
+If you're having difficulties solving this exercise, go through [this](../../../reading/README.md#pointer-operations-and-pointer-arithmetic) reading material.
+


There are 2 blank lines here, that's the problem.

teodutu · 2024-03-05T14:30:57Z

chapters/memory-layout/memory-operations/drills/tasks/pixels/support/pixel.h

+
+	for (int i = 0; i < height; ++i)
+		for (int j = 0; j < width; ++j)
+			pix_array[i][j] = generate_pixel(rand() % 256,


Replace rand() with rand_r().

dumitrache-adrian92 · 2024-03-05T14:39:01Z

You forgot to address 2 of my previous comments. Maybe you forgot to git add those files?

Yep :)))

teodutu

Sorry for overlooking this earlier, but demos/array-vs-pointer should be guides/array-vs-pointer, just like segfault/.

chapters/memory-layout/memory-operations/demos/array-vs-pointer/array_vs_pointer.c

config.yaml

Add reading and tasks for lab 2 and modify config.yaml to render the new content. Signed-off-by: Adrian-George Dumitrache <[email protected]>

github-actions · 2024-03-06T09:58:15Z

Published at https://cs-pub-ro.github.io/hardware-software-interface/5/

teodutu

I think it's OK

dumitrache-adrian92 commented Mar 1, 2024

View reviewed changes

chapters/memory-layout/memory-operations/reading/README.md Outdated Show resolved Hide resolved

dumitrache-adrian92 force-pushed the lab2-openedu branch from a9d2877 to 8d5858d Compare March 1, 2024 15:31

teodutu self-assigned this Mar 2, 2024

dumitrache-adrian92 added the needs-rendering The PR makes changes to the website that need to be rendered label Mar 2, 2024

dumitrache-adrian92 force-pushed the lab2-openedu branch from 8d5858d to 2564766 Compare March 2, 2024 20:53

dumitrache-adrian92 requested review from teodutu, cristian-vijelie and Dave080302 March 2, 2024 20:55

dumitrache-adrian92 added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 2, 2024

teodutu requested changes Mar 2, 2024

View reviewed changes

dumitrache-adrian92 force-pushed the lab2-openedu branch 2 times, most recently from c687bf4 to 25f4c47 Compare March 3, 2024 00:09

dumitrache-adrian92 requested a review from teodutu March 3, 2024 00:09

dumitrache-adrian92 added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 3, 2024

Dave080302 reviewed Mar 3, 2024

View reviewed changes

dumitrache-adrian92 force-pushed the lab2-openedu branch from 25f4c47 to 348a597 Compare March 3, 2024 09:39

cristian-vijelie requested changes Mar 3, 2024

View reviewed changes

dumitrache-adrian92 force-pushed the lab2-openedu branch from 348a597 to fbf16df Compare March 3, 2024 17:05

dumitrache-adrian92 requested review from cristian-vijelie and Dave080302 March 3, 2024 17:22

dumitrache-adrian92 added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 3, 2024

teodutu requested changes Mar 4, 2024

View reviewed changes

dumitrache-adrian92 force-pushed the lab2-openedu branch from fbf16df to 0c63857 Compare March 5, 2024 10:49

dumitrache-adrian92 requested a review from teodutu March 5, 2024 10:50

teodutu requested changes Mar 5, 2024

View reviewed changes

dumitrache-adrian92 force-pushed the lab2-openedu branch from 0c63857 to 56be8d7 Compare March 5, 2024 14:37

teodutu requested changes Mar 5, 2024

View reviewed changes

chapters/memory-layout/memory-operations/demos/array-vs-pointer/array_vs_pointer.c Outdated Show resolved Hide resolved

config.yaml Show resolved Hide resolved

dumitrache-adrian92 force-pushed the lab2-openedu branch from 56be8d7 to 71d8c74 Compare March 6, 2024 09:05

memory-layout/memory-operations-and-GDB: Add reading and tasks

f7f1578

Add reading and tasks for lab 2 and modify config.yaml to render the new content. Signed-off-by: Adrian-George Dumitrache <[email protected]>

dumitrache-adrian92 force-pushed the lab2-openedu branch from 71d8c74 to f7f1578 Compare March 6, 2024 09:09

teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 6, 2024

teodutu approved these changes Mar 6, 2024

View reviewed changes

teodutu merged commit 8576090 into cs-pub-ro:main Mar 6, 2024
2 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

memory-layout/memory-operations-and-GDB: Add reading and tasks #5

memory-layout/memory-operations-and-GDB: Add reading and tasks #5

dumitrache-adrian92 commented Mar 1, 2024

github-actions bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024

teodutu left a comment

github-actions bot commented Mar 3, 2024

dumitrache-adrian92 commented Mar 3, 2024

Dave080302 Mar 3, 2024

dumitrache-adrian92 Mar 3, 2024

dumitrache-adrian92 commented Mar 3, 2024

github-actions bot commented Mar 3, 2024

teodutu left a comment

teodutu Mar 4, 2024

teodutu Mar 5, 2024

teodutu Mar 4, 2024

teodutu Mar 5, 2024

teodutu left a comment

teodutu Mar 5, 2024

teodutu Mar 5, 2024

dumitrache-adrian92 commented Mar 5, 2024

teodutu left a comment

github-actions bot commented Mar 6, 2024

teodutu left a comment

		Implement the functions [memcpy](http://www.cplusplus.com/reference/cstring/memcpy/), [strcpy](http://www.cplusplus.com/reference/cstring/strcpy/), and [strcmp](http://www.cplusplus.com/reference/cstring/strcmp/) using pointer operations.

		If you're having difficulties solving this exercise, go through [this](../../../reading/README.md#pointer-operations-and-pointer-arithmetic) reading material.

	pix_array[i][j] = generate_pixel(rand() % 256,
	pix_array[i][j] = generate_pixel(rand() % 256,

memory-layout/memory-operations-and-GDB: Add reading and tasks #5

memory-layout/memory-operations-and-GDB: Add reading and tasks #5

Conversation

dumitrache-adrian92 commented Mar 1, 2024

Prerequisite Checklist

Description of changes

github-actions bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024

teodutu left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2024

dumitrache-adrian92 commented Mar 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dumitrache-adrian92 commented Mar 3, 2024

github-actions bot commented Mar 3, 2024

teodutu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teodutu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dumitrache-adrian92 commented Mar 5, 2024

teodutu left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 6, 2024

teodutu left a comment

Choose a reason for hiding this comment