Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SHA3 Scalar and Simd256 functions #439

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Rename SHA3 Scalar and Simd256 functions #439

merged 2 commits into from
Dec 6, 2023

Conversation

mamonet
Copy link
Member

@mamonet mamonet commented Dec 6, 2023

This patch uses the new hacl naming convention for SHA3 Scalar and Simd256 functions.

NOTE naming convention is slightly modified to distinguish between scalar and original SHA3 functions until we remove the latter.

@mamonet mamonet requested a review from a team as a code owner December 6, 2023 11:54
@cla-bot cla-bot bot added the cla-signed label Dec 6, 2023
@coveralls
Copy link

coveralls commented Dec 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7116150594

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.089%
Totals Coverage Status
Change from base Build 7085212369: 0.0%
Covered Lines: 37671
Relevant Lines: 63753
💛 - Coveralls

franziskuskiefer
franziskuskiefer approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@franziskuskiefer
Copy link
Member

@mamonet CI is failing. Can you check what's going on? I retriggered a failing job.

@franziskuskiefer franziskuskiefer mentioned this pull request Dec 6, 2023
Merged
@franziskuskiefer franziskuskiefer merged commit 8e7f025 into cryspen:dev Dec 6, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
HACL Packages
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mamonet @coveralls @franziskuskiefer