Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hacl sha3 mb #149

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Use hacl sha3 mb #149

merged 17 commits into from
Dec 7, 2023

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Dec 5, 2023

Use HACL SHA3 mb for 4xXOF in kyber.

Waiting on cryspen/hacl-packages#439 (merged)

Closing #146 #102

This was linked to issues Dec 5, 2023
@franziskuskiefer franziskuskiefer marked this pull request as ready for review December 6, 2023 19:31
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks look good.

On a Dell XPS13 (KabyLake)

  • Keygen: 41 microseconds
  • Encapsulation: 45 microseconds
  • Decapsulation: 52 microseconds

Between 30-40% faster than with scalar SHA-3

src/hacl/sha3.rs Outdated Show resolved Hide resolved
proofs/fstar/extraction/Libcrux.Digest.fsti Show resolved Hide resolved
@franziskuskiefer franziskuskiefer merged commit 456b566 into dev Dec 7, 2023
14 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/hacl-sha3-mb branch December 7, 2023 09:26
This was referenced Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add SHA3-mb to libcrux Use SHA3-mb in Kyber
3 participants