Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cwhub - refact Downloader #3382

Merged
merged 3 commits into from
Dec 27, 2024

lint

96431f7
Select commit
Loading
Failed to load commit list.
Merged

pkg/cwhub - refact Downloader #3382

lint
96431f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2024 in 1s

58.60% (target 0.00%)

View this Pull Request on Codecov

58.60% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 66.88312% with 51 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (fc17c0c) to head (96431f7).

Files with missing lines Patch % Lines
pkg/cwhub/download.go 55.22% 28 Missing and 2 partials ⚠️
cmd/crowdsec-cli/cliitem/item.go 65.38% 6 Missing and 3 partials ⚠️
pkg/hubtest/hubtest.go 0.00% 2 Missing ⚠️
cmd/crowdsec-cli/cliconsole/console.go 0.00% 1 Missing ⚠️
cmd/crowdsec-cli/clihub/hub.go 90.90% 0 Missing and 1 partial ⚠️
cmd/crowdsec-cli/cliitem/suggest.go 50.00% 1 Missing ⚠️
cmd/crowdsec-cli/clilapi/context.go 66.66% 1 Missing ⚠️
cmd/crowdsec-cli/clisupport/support.go 50.00% 1 Missing ⚠️
cmd/crowdsec-cli/config_restore.go 75.00% 1 Missing ⚠️
cmd/crowdsec/serve.go 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
+ Coverage   58.59%   58.60%   +0.01%     
==========================================
  Files         357      356       -1     
  Lines       38209    38214       +5     
==========================================
+ Hits        22388    22397       +9     
+ Misses      13906    13902       -4     
  Partials     1915     1915

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov