Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cwhub - refact Downloader #3382

Merged
merged 3 commits into from
Dec 27, 2024
Merged

pkg/cwhub - refact Downloader #3382

merged 3 commits into from
Dec 27, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 26, 2024

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Dec 26, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as ready for review December 26, 2024 14:28
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 66.88312% with 51 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (fc17c0c) to head (96431f7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cwhub/download.go 55.22% 28 Missing and 2 partials ⚠️
cmd/crowdsec-cli/cliitem/item.go 65.38% 6 Missing and 3 partials ⚠️
pkg/hubtest/hubtest.go 0.00% 2 Missing ⚠️
cmd/crowdsec-cli/cliconsole/console.go 0.00% 1 Missing ⚠️
cmd/crowdsec-cli/clihub/hub.go 90.90% 0 Missing and 1 partial ⚠️
cmd/crowdsec-cli/cliitem/suggest.go 50.00% 1 Missing ⚠️
cmd/crowdsec-cli/clilapi/context.go 66.66% 1 Missing ⚠️
cmd/crowdsec-cli/clisupport/support.go 50.00% 1 Missing ⚠️
cmd/crowdsec-cli/config_restore.go 75.00% 1 Missing ⚠️
cmd/crowdsec/serve.go 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
+ Coverage   58.59%   58.60%   +0.01%     
==========================================
  Files         357      356       -1     
  Lines       38209    38214       +5     
==========================================
+ Hits        22388    22397       +9     
+ Misses      13906    13902       -4     
  Partials     1915     1915              
Flag Coverage Δ
bats 41.63% <61.03%> (+0.05%) ⬆️
unit-linux 33.10% <26.62%> (+0.04%) ⬆️
unit-windows 28.40% <26.62%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from blotus December 26, 2024 14:46
@mmetc mmetc merged commit 78f4b85 into master Dec 27, 2024
17 checks passed
@mmetc mmetc deleted the cwhub-downloader branch December 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants