Bump build version to its latest #72
Conversation
| @@ -1,3 +1,5 @@ | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Hrm, I'm not sure these should have all reappeared.
There was a problem hiding this comment.
Hi @negz I checked everywhere, different go versions, and different controller-gen versions, I could not figure it out. Then I noticed provider-aws hit the same issue https://github.com/crossplane/provider-aws/pull/602/files to solve this similar issue you fixied in upbound/build#140.
Besides, @muvaf figured it out https://github.com/crossplane/provider-aws/pull/602/files#r718819950.
I think we need to update build submodule to latest to so that crd cleanup runs properly to delete these two lines.
So for this PR, can it be accepted?
|
I will recheck this one after #95 is merged. Thanks. |
By bumping the version of build submodule, it can fix the issue of make reviewable. Signed-off-by: Zheng Xi Zhou <[email protected]>
Signed-off-by: Zheng Xi Zhou <[email protected]>
Signed-off-by: Zheng Xi Zhou <[email protected]>
Update latest build to fix e2e issue Signed-off-by: zzxwill <[email protected]>
|
@negz @muvaf @hasheddan Do you have any suggestions on continuing this PR? |
Description of your changes
By bumping the version of build submodule, it can fix
the issue of
make reviewable.Fixes #70
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested